A settled top-level `read_image` call printed its raw attachment object as
literal text in the tool card — `{"type":"image","attachment":{…}}` —
instead of the image, because no presentation metadata told a client card
how to present the reference and the tool-card layer had no image concept.
Host: `read_image` declares an `output.presentationMeta` persisting
`{ path }` only. The attachment reference deliberately lives in the
settled result content — the single record a `tools/post-execute`
replacement rewrites — not in `meta`; the id is opaque and
provider-owned, checked for existence only.
Client: `imageCardModel` derives the card from the call head, the meta
path, the result's own image block, and a shape-matched envelope. ToolRow
gains an `image` card slot; the `read_image` toolview declares the
Tool-owned `tool.call.images` slot as its child and dispatches the
gallery through it. ui-chat down-threads the session-authorized loader
(`ChatNodeOwnerProps.loadImage`), so the tool layer supplies only derived
references plus the loader and never imports an attachment
implementation; ui-attachment fills the slot with its message gallery
renderer. The card keeps the envelope text below the gallery for the
no-attachment-plugin deployment. An image-bearing tool registers a keyed
toolview; the generic fallback keeps its flattened text. `read_image`
joins the read variant with its own locale title key; both rows share
`read-family-row.tsx`.
Verification: `read-image.spec.ts` (metadata projection, envelope by
shape, reference narrowing, real-execution round trip, rejection
branches incl. non-digest ids), `image-card.client.spec.tsx` (derivation,
row render site dispatching the slot, keyed registration with the
child-slot declaration, empty-slot fallbacks, media-type enum), keyless
snapshots (`read-image-gif` added; read-image/-dimension/-reencode
updated to the `{path}` meta), five injected-defect negative controls,
and a demo GIF recorded from this PR's head through the official
image-capable model.
747 lines
36 KiB
TypeScript
747 lines
36 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import { cleanup, fireEvent, render } from '@testing-library/react'
|
|
import {
|
|
bindSnapshotSelector, conversationSnapshot, sessionSnapshot, workspaceSnapshot,
|
|
} from '@deepseek-ai/dsh-client-test-runtime'
|
|
import { createSnapshotStore } from '@deepseek-ai/dsh-client-store'
|
|
import type {
|
|
ChatSnapshot, ConversationNode, RunningToolCall, SelectionTarget, ToolResultNode,
|
|
} from '@deepseek-ai/dsh-client-ui-chat/client'
|
|
import type { SessionListState } from '@deepseek-ai/dsh-api-session-controller/client'
|
|
import type { SessionId } from '@deepseek-ai/dsh-session/types'
|
|
import { makeTranslate } from '@deepseek-ai/dsh-client-test-runtime'
|
|
import { en as commonEn } from '@deepseek-ai/dsh-client-locale/src/locales/en.ts'
|
|
import { zh as commonZh } from '@deepseek-ai/dsh-client-locale/src/locales/zh.ts'
|
|
import {
|
|
localizeTerminalCardModel, terminalCardModel, terminalFailed,
|
|
} from '../src/client/tool/models/terminal-card-model.ts'
|
|
import { createChatStore } from '@deepseek-ai/dsh-client-ui-chat/src/client/stores.ts'
|
|
import { GenericToolCard, type GenericToolCardProps } from '../src/client/tool/toolviews/GenericToolCard.tsx'
|
|
import { DetailsPanel } from '@deepseek-ai/dsh-client-ui-chat/src/client/details/DetailsPanel.tsx'
|
|
import { BashRow } from '../src/client/tool/toolviews/bash-sample.tsx'
|
|
import { renderToolDetails, toolChatSnapshot, useEmptyTrajectory } from './tool-details-render.client.tsx'
|
|
import { en, zh } from '@deepseek-ai/dsh-client-ui-conversation/src/client/locales.ts'
|
|
import { zh as chatZh } from '@deepseek-ai/dsh-client-ui-chat/src/client/locale.ts'
|
|
|
|
type BashRowProps = Parameters<typeof BashRow>[0]
|
|
|
|
const t: GenericToolCardProps['t'] = makeTranslate(zh, commonZh)
|
|
const enT: GenericToolCardProps['t'] = makeTranslate(en, commonEn)
|
|
const chatT = makeTranslate(chatZh, commonZh)
|
|
|
|
afterEach(cleanup)
|
|
|
|
/**
|
|
* Match an output line with its interior whitespace intact: the column
|
|
* alignment this card exists to preserve is exactly what the default
|
|
* whitespace-collapsing matcher would hide.
|
|
*/
|
|
const RAW = { normalizer: (text: string) => text }
|
|
|
|
/** The rendered card's run-state dot state, so a render site cannot silently drop it. */
|
|
function runStateOf(container: HTMLElement): string | null {
|
|
return container.querySelector('[data-terminal] [data-state]')?.getAttribute('data-state') ?? null
|
|
}
|
|
|
|
const SID = 's1' as SessionId
|
|
|
|
const ARGS = '{"command":"ls -la","description":"List files"}'
|
|
|
|
const shellArgs = (over: Record<string, unknown> = {}): string => JSON.stringify({
|
|
command: 'ls -la', description: 'List files', ...over,
|
|
})
|
|
|
|
const running = (over?: Partial<RunningToolCall>): RunningToolCall => ({
|
|
callId: 'c1', name: 'bash', argsRaw: ARGS,
|
|
turn: 1, step: 1, time: 1_000, subCalls: [], ...over,
|
|
})
|
|
|
|
const settled = (over?: Partial<ToolResultNode>): ToolResultNode => ({
|
|
kind: 'tool-result', seq: 10, time: 2_000, callId: 'c1',
|
|
call: { name: 'bash', argsRaw: ARGS },
|
|
callTime: 1_000,
|
|
content: [{ type: 'text', text: 'a.ts b.ts\nc.ts d.ts\n' }], isError: false,
|
|
subCalls: [], ...over,
|
|
})
|
|
|
|
describe('terminalCardModel', () => {
|
|
it('derives a running standard-shell card from raw arguments', () => {
|
|
expect(terminalCardModel(running({ argsRaw: shellArgs({ workdir: '/projects/app' }) }))).toEqual({
|
|
copy: { kind: 'shell', command: 'ls -la', description: 'List files' },
|
|
card: {
|
|
cwd: '/projects/app', output: undefined,
|
|
exitCode: undefined, signal: undefined, running: true,
|
|
},
|
|
})
|
|
})
|
|
|
|
it('derives a settled standard-shell card and removes its final exit marker', () => {
|
|
expect(terminalCardModel(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ workdir: '/projects/app' }) },
|
|
content: [{ type: 'text', text: 'boom\n[exit code: 2]' }],
|
|
}))).toEqual({
|
|
copy: { kind: 'shell', command: 'ls -la', description: 'List files' },
|
|
card: {
|
|
cwd: '/projects/app', output: 'boom',
|
|
exitCode: 2, signal: undefined, running: false,
|
|
},
|
|
})
|
|
expect(terminalCardModel(settled({
|
|
content: [{ type: 'text', text: 'gone\n[killed by signal: SIGTERM]' }],
|
|
}))?.card).toMatchObject({ output: 'gone', signal: 'SIGTERM' })
|
|
})
|
|
|
|
it('flags a failing exit as terminalFailed; clean exits and running cards are not', () => {
|
|
// isError stays false on a failing command (the exit status is result
|
|
// data), so this predicate is the row's only failure signal.
|
|
expect(terminalFailed(terminalCardModel(settled({
|
|
content: [{ type: 'text', text: 'boom\n[exit code: 2]' }],
|
|
}))!)).toBe(true)
|
|
expect(terminalFailed(terminalCardModel(settled({
|
|
content: [{ type: 'text', text: 'gone\n[killed by signal: SIGTERM]' }],
|
|
}))!)).toBe(true)
|
|
expect(terminalFailed(terminalCardModel(settled())!)).toBe(false)
|
|
expect(terminalFailed(terminalCardModel(running())!)).toBe(false)
|
|
})
|
|
|
|
it('keeps status text that has no terminal pill and requires a leading newline', () => {
|
|
expect(terminalCardModel(settled({
|
|
content: [{ type: 'text', text: 'timed out\n[timed out after 1000ms]\n[exit code: 2]' }],
|
|
}))?.card).toMatchObject({ output: 'timed out\n[timed out after 1000ms]', exitCode: 2 })
|
|
expect(terminalCardModel(settled({
|
|
content: [{ type: 'text', text: '[exit code: 5]' }],
|
|
}))?.card).toMatchObject({ output: '[exit code: 5]', exitCode: 0 })
|
|
})
|
|
|
|
it('resolves the raw workdir against the session workspace', () => {
|
|
// Omitted workdir — the common bash call — IS the session workspace.
|
|
expect(terminalCardModel(settled(), '/w/app')?.card.cwd).toBe('/w/app')
|
|
// A relative workdir joins under it.
|
|
expect(terminalCardModel(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ workdir: 'packages/ui' }) },
|
|
}), '/w/app')?.card.cwd).toBe('/w/app/packages/ui')
|
|
// An absolute one is used as-is.
|
|
expect(terminalCardModel(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ workdir: '/srv/other' }) },
|
|
}), '/w/app')?.card.cwd).toBe('/srv/other')
|
|
// With no session cwd there is nothing to resolve against: a relative path
|
|
// stays as authored and an omitted one stays absent (a bare `$` prompt).
|
|
expect(terminalCardModel(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ workdir: 'packages/ui' }) },
|
|
}))?.card.cwd).toBe('packages/ui')
|
|
expect(terminalCardModel(settled())?.card.cwd).toBeUndefined()
|
|
// The running arm resolves identically.
|
|
expect(terminalCardModel(running(), '/w/app')?.card.cwd).toBe('/w/app')
|
|
})
|
|
|
|
it('normalizes a relative workdir so the label names the directory actually used', () => {
|
|
// The bash executor resolves the workdir before running, so `..` against
|
|
// /w/app runs in /w — the card must say `w`, not `..`.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '..' }) } }), '/w/app')?.card.cwd).toBe('/w')
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '.' }) } }), '/w/app')?.card.cwd).toBe('/w/app')
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '../sibling' }) } }), '/w/app')?.card.cwd).toBe('/w/sibling')
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: './nested/../other' }) } }), '/w/app')?.card.cwd).toBe('/w/app/other')
|
|
// A `..` that would climb past the root is dropped, as a filesystem does.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '../../..' }) } }), '/w')?.card.cwd).toBe('/')
|
|
// An absolute path carrying segments normalizes too.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '/srv/./app/../other' }) } }), '/w/app')?.card.cwd).toBe('/srv/other')
|
|
// A Windows path keeps its separators.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: 'C:\\ws\\app\\..' }) } }), '/w')?.card.cwd).toBe('C:\\ws')
|
|
// Without a session cwd a relative `..` has nothing to resolve against, so
|
|
// it survives as authored rather than being silently dropped.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '../elsewhere' }) } }))?.card.cwd).toBe('../elsewhere')
|
|
})
|
|
|
|
it('keeps a UNC server and share as an unpoppable root', () => {
|
|
// Windows cannot climb above a share, so `..` from the share root stays put.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '..' }) } }), '\\\\server\\share')?.card.cwd).toBe('\\\\server\\share')
|
|
// Below the share it pops normally, keeping the UNC separators.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '..' }) } }), '\\\\server\\share\\app')?.card.cwd).toBe('\\\\server\\share')
|
|
// Several `..` cannot escape the root either.
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: shellArgs({ workdir: '../../..' }) } }), '\\\\server\\share\\app')?.card.cwd).toBe('\\\\server\\share')
|
|
})
|
|
|
|
it('supports terminal_send without giving background or failed sends a terminal card', () => {
|
|
const argsRaw = JSON.stringify({ sessionId: 'pty-3', text: 'make' })
|
|
const run = running({ name: 'terminal_send', argsRaw })
|
|
expect(terminalCardModel(run, '/w/app')).toMatchObject({
|
|
copy: { kind: 'terminal-send', text: 'make', sessionId: 'pty-3' },
|
|
card: { cwd: '/w/app', running: true },
|
|
})
|
|
const done = settled({ call: { name: 'terminal_send', argsRaw }, content: [{ type: 'text', text: 'ok' }] })
|
|
expect(localizeTerminalCardModel(terminalCardModel(done)!, enT)).toMatchObject({
|
|
description: 'Terminal pty-3', card: { command: 'make', output: 'ok', running: false },
|
|
})
|
|
expect(terminalCardModel(settled({
|
|
call: { name: 'terminal_send', argsRaw: JSON.stringify({ sessionId: 'pty-3', text: 'make', run_in_background: true }) },
|
|
}))).toBeNull()
|
|
expect(terminalCardModel(settled({ ...done, isError: true }))).toBeNull()
|
|
})
|
|
|
|
it('preserves persistent-shell running cards and settled generic output', () => {
|
|
const persistent = JSON.stringify({ command: 'pwd' })
|
|
expect(terminalCardModel(running({ argsRaw: persistent }))).toMatchObject({
|
|
copy: { kind: 'shell', command: 'pwd', description: undefined }, card: { running: true },
|
|
})
|
|
expect(terminalCardModel(running({ name: 'pwsh', argsRaw: persistent }))).toMatchObject({
|
|
copy: { kind: 'shell', command: 'pwd', description: undefined }, card: { running: true },
|
|
})
|
|
expect(terminalCardModel(settled({ call: { name: 'bash', argsRaw: persistent } }))).toBeNull()
|
|
expect(terminalCardModel(settled({ call: { name: 'pwsh', argsRaw: persistent } }))).toBeNull()
|
|
})
|
|
|
|
it('derives the standard pwsh card from the same raw status markers', () => {
|
|
expect(terminalCardModel(settled({
|
|
call: { name: 'pwsh', argsRaw: ARGS },
|
|
content: [{ type: 'text', text: 'failed\n[exit code: 3]' }],
|
|
}))).toMatchObject({
|
|
copy: { kind: 'shell', command: 'ls -la', description: 'List files' },
|
|
card: { output: 'failed', exitCode: 3, running: false },
|
|
})
|
|
})
|
|
|
|
it('keeps terminal_send copy semantic until the render locale is known', () => {
|
|
const model = terminalCardModel(running({
|
|
name: 'terminal_send',
|
|
argsRaw: JSON.stringify({ sessionId: 'pty-3', text: '' }),
|
|
}))!
|
|
expect(model.copy).toEqual({ kind: 'terminal-send', text: '', sessionId: 'pty-3' })
|
|
expect(localizeTerminalCardModel(model, t)).toMatchObject({
|
|
description: '终端 pty-3', card: { command: '(发送输入)' },
|
|
})
|
|
expect(localizeTerminalCardModel(model, enT)).toMatchObject({
|
|
description: 'Terminal pty-3', card: { command: '(send input)' },
|
|
})
|
|
})
|
|
|
|
it('returns null without a paired call and for Code Dispatch children', () => {
|
|
expect(terminalCardModel(settled({ call: null }))).toBeNull()
|
|
expect(terminalCardModel(settled({ parentCallId: 'parent' }))).toBeNull()
|
|
expect(terminalCardModel(running({ parentCallId: 'parent' }))).toBeNull()
|
|
})
|
|
|
|
it('returns null for background, errors, malformed args, unsupported tools, and non-text results', () => {
|
|
expect(terminalCardModel(running({ argsRaw: shellArgs({ run_in_background: true }) }))).toBeNull()
|
|
expect(terminalCardModel(settled({ isError: true }))).toBeNull()
|
|
expect(terminalCardModel(running({ argsRaw: '{' }))).toBeNull()
|
|
expect(terminalCardModel(running({ name: 'read' }))).toBeNull()
|
|
expect(terminalCardModel(settled({ content: [] }))).toBeNull()
|
|
expect(terminalCardModel(settled({ content: [{ type: 'text', text: 'a' }, { type: 'text', text: 'b' }] }))).toBeNull()
|
|
})
|
|
|
|
it.each([
|
|
['timeout type', { timeoutMs: '1000' }],
|
|
['timeout value', { timeoutMs: 0 }],
|
|
['workdir type', { workdir: 7 }],
|
|
['background type', { run_in_background: 'yes' }],
|
|
['permission type', { sandbox_permissions: 7, justification: 'Need access' }],
|
|
['permission value', { sandbox_permissions: 'read-only', justification: 'Need access' }],
|
|
['missing justification', { sandbox_permissions: 'workspace-write' }],
|
|
['orphan justification', { justification: 'Need access' }],
|
|
['blank justification', { sandbox_permissions: 'workspace-write', justification: ' ' }],
|
|
])('keeps malformed standard-shell optional fields generic: %s', (_label, fields) => {
|
|
expect(terminalCardModel(running({ argsRaw: shellArgs(fields) }))).toBeNull()
|
|
})
|
|
|
|
it('accepts valid optional and unknown standard-shell fields on the open parameter root', () => {
|
|
expect(terminalCardModel(running({ argsRaw: shellArgs({
|
|
timeoutMs: 1_000,
|
|
sandbox_permissions: 'workspace-write',
|
|
justification: 'Write generated output',
|
|
extension: { version: 1 },
|
|
}) }))).not.toBeNull()
|
|
})
|
|
|
|
it('validates terminal_send optional fields while retaining open-root extensions', () => {
|
|
const send = (over: Record<string, unknown>) => running({
|
|
name: 'terminal_send',
|
|
argsRaw: JSON.stringify({ sessionId: 'pty-1', text: 'make', ...over }),
|
|
})
|
|
expect(terminalCardModel(send({ submit: 'yes' }))).toBeNull()
|
|
expect(terminalCardModel(send({ run_in_background: 'yes' }))).toBeNull()
|
|
expect(terminalCardModel(send({ submit: false, run_in_background: false }))).not.toBeNull()
|
|
expect(terminalCardModel(send({ extension: { version: 1 } }))).not.toBeNull()
|
|
})
|
|
|
|
it('keeps persistent shells with open-root extension fields on the running-card path', () => {
|
|
const argsRaw = JSON.stringify({ command: 'pwd', extension: { version: 1 } })
|
|
expect(terminalCardModel(running({ argsRaw }))).not.toBeNull()
|
|
expect(terminalCardModel(running({ name: 'pwsh', argsRaw }))).not.toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('chat row terminal body', () => {
|
|
const ownerProps = (block: RunningToolCall | ToolResultNode): GenericToolCardProps => ({
|
|
loadImage: vi.fn(() => Promise.reject(new Error('not used'))),
|
|
callId: 'c1', toolName: 'bash', block, openFile: vi.fn(), t,
|
|
})
|
|
|
|
/** The whole summary row is the expand toggle (ToolRow's unified interaction). */
|
|
const toggleRow = (view: { container: HTMLElement }) => {
|
|
fireEvent.click(view.container.querySelector('[data-expandable]')!)
|
|
}
|
|
|
|
it('the expanded body is the command output inside the row scroll container', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled())} />)
|
|
// Collapsed: the one-line summary row only, no output.
|
|
expect(view.getByText('List files')).toBeTruthy()
|
|
expect(view.queryByText(/a\.ts/)).toBeNull()
|
|
toggleRow(view)
|
|
expect(view.getByText('a.ts b.ts', RAW)).toBeTruthy()
|
|
expect(view.getByText('ls -la')).toBeTruthy()
|
|
// The args JSON body the generic path would have shown is gone.
|
|
expect(view.queryByText(/"command"/)).toBeNull()
|
|
})
|
|
|
|
it('a long output renders in full — the scroll container replaces the middle collapse', () => {
|
|
const lines = Array.from({ length: 20 }, (_, i) => `line-${i}`)
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
content: [{ type: 'text', text: `${lines.join('\n')}\n` }],
|
|
}))} />)
|
|
toggleRow(view)
|
|
expect(view.getByText('line-5')).toBeTruthy()
|
|
expect(view.getByText('line-19')).toBeTruthy()
|
|
expect(view.queryByText(/其余/)).toBeNull()
|
|
})
|
|
|
|
it('renders a multi-line command as one prompt row per line', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ command: 'ls -la\necho done' }) },
|
|
}))} />)
|
|
toggleRow(view)
|
|
const rows = view.container.querySelectorAll('[class^="_promptLine_"]')
|
|
expect([...rows].map(row => row.textContent)).toEqual(['$ls -la', '$echo done'])
|
|
// Still one dot for the call, on the first row.
|
|
expect(view.container.querySelectorAll('[data-terminal] [data-state]')).toHaveLength(1)
|
|
})
|
|
|
|
it('the fallback row shows the call description', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ description: 'Terminal 3' }) },
|
|
}))} />)
|
|
expect(view.getByText('Terminal 3')).toBeTruthy()
|
|
expect(view.queryByText('List files')).toBeNull()
|
|
})
|
|
|
|
it('keeps the call description visible once the terminal card is expanded', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ description: 'Terminal 3' }) },
|
|
}))} />)
|
|
expect(view.getByText('Terminal 3')).toBeTruthy()
|
|
toggleRow(view)
|
|
expect(view.container.querySelector('[data-terminal]')).not.toBeNull()
|
|
expect(view.getByText('Terminal 3')).toBeTruthy()
|
|
})
|
|
|
|
it('a running terminal call expands to the prompt line with no output yet', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(running())} />)
|
|
toggleRow(view)
|
|
expect(view.getByText('ls -la')).toBeTruthy()
|
|
expect(view.queryByText('复制')).toBeNull()
|
|
// The card states its own run state: a running command reads as running
|
|
// even though it has no output yet to distinguish it from an empty settle.
|
|
expect(runStateOf(view.container)).toBe('ongoing')
|
|
})
|
|
|
|
it.each([
|
|
{ locale: 'zh', translate: t, description: '终端 pty-3', command: '(发送输入)' },
|
|
{ locale: 'en', translate: enT, description: 'Terminal pty-3', command: '(send input)' },
|
|
])('renders terminal_send copy through the $locale locale', ({ translate, description, command }) => {
|
|
const block = running({
|
|
name: 'terminal_send',
|
|
argsRaw: JSON.stringify({ sessionId: 'pty-3', text: '' }),
|
|
})
|
|
const view = render(<GenericToolCard {...ownerProps(block)} toolName="terminal_send" t={translate} />)
|
|
expect(view.getByText(description)).toBeTruthy()
|
|
toggleRow(view)
|
|
expect(view.getByText(command)).toBeTruthy()
|
|
})
|
|
|
|
it('a non-terminal call keeps the args-JSON text body', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ run_in_background: true }) },
|
|
}))} />)
|
|
toggleRow(view)
|
|
expect(view.getByText(/"command"/)).toBeTruthy()
|
|
})
|
|
|
|
it('malformed empty args use the generic output body', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
call: { name: 'bash', argsRaw: '' },
|
|
}))} />)
|
|
toggleRow(view)
|
|
expect(view.container.querySelector('[class*="_ioText_"]')?.textContent).toBe('a.ts b.ts\nc.ts d.ts\n')
|
|
expect(view.container.querySelector('[data-terminal]')).toBeNull()
|
|
})
|
|
|
|
it('a failing exit status surfaces as the collapsed row\'s error state', () => {
|
|
const view = render(<GenericToolCard {...ownerProps(settled({
|
|
content: [{ type: 'text', text: 'boom\n[exit code: 2]' }],
|
|
}))} />)
|
|
expect(view.container.querySelector('[data-state]')?.getAttribute('data-state')).toBe('error')
|
|
})
|
|
})
|
|
|
|
describe('BashRow terminal card', () => {
|
|
const list = () => createSnapshotStore<SessionListState>({
|
|
ids: [SID],
|
|
byId: { [SID]: { id: SID, displayTitle: 'r', running: false, blank: false, updatedAt: 0 } },
|
|
current: undefined,
|
|
phase: 'ready',
|
|
subagentsByParent: {}, jobsBySession: {},
|
|
currentAddress: undefined,
|
|
})
|
|
|
|
const rowProps = (block: RunningToolCall | ToolResultNode): BashRowProps => ({
|
|
callId: 'c1', toolName: 'bash', block, openFile: vi.fn(),
|
|
sessionId: SID, useSessions: bindSnapshotSelector(list()),
|
|
t,
|
|
} as unknown as BashRowProps)
|
|
|
|
it('collapses to the summary row; the whole row toggles the command output', () => {
|
|
const view = render(<BashRow {...rowProps(settled())} />)
|
|
expect(view.getByText('List files')).toBeTruthy()
|
|
expect(view.queryByText(/a\.ts/)).toBeNull()
|
|
fireEvent.click(view.container.querySelector('[data-expandable]')!)
|
|
expect(view.getByText('a.ts b.ts', RAW)).toBeTruthy()
|
|
expect(view.getByText('复制')).toBeTruthy()
|
|
// Collapse back in place: the summary row returns, the card unmounts.
|
|
fireEvent.click(view.container.querySelector('[data-expandable]')!)
|
|
expect(view.queryByText(/a\.ts/)).toBeNull()
|
|
expect(view.getByText('List files')).toBeTruthy()
|
|
})
|
|
|
|
// The row's leading StateDot and the card's run-state dot describe the same
|
|
// command, so a running row whose card claimed 'done' would be a contradiction
|
|
// the reader sees on one line.
|
|
it('agrees with the summary row about the run state', () => {
|
|
const runningView = render(<BashRow {...rowProps(running())} />)
|
|
expect(runningView.container.querySelector('[data-variant="bash"]')?.getAttribute('data-state')).toBe('running')
|
|
fireEvent.click(runningView.container.querySelector('[data-expandable]')!)
|
|
expect(runStateOf(runningView.container)).toBe('ongoing')
|
|
cleanup()
|
|
const settledView = render(<BashRow {...rowProps(settled())} />)
|
|
expect(settledView.container.querySelector('[data-variant="bash"]')?.getAttribute('data-state')).toBe('ok')
|
|
fireEvent.click(settledView.container.querySelector('[data-expandable]')!)
|
|
expect(runStateOf(settledView.container)).toBe('done')
|
|
})
|
|
|
|
it('a failing exit status surfaces as the collapsed row\'s error state', () => {
|
|
const view = render(<BashRow {...rowProps(settled({
|
|
content: [{ type: 'text', text: 'boom\n[exit code: 2]' }],
|
|
}))} />)
|
|
expect(view.container.querySelector('[data-variant="bash"]')?.getAttribute('data-state')).toBe('error')
|
|
})
|
|
|
|
it('shows the call description as the terminal summary', () => {
|
|
const view = render(<BashRow {...rowProps(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ description: 'Terminal 3' }) },
|
|
}))} />)
|
|
expect(view.getByText('Terminal 3')).toBeTruthy()
|
|
expect(view.queryByText('List files')).toBeNull()
|
|
})
|
|
|
|
it('expands a settled persistent shell through the generic input/output card', () => {
|
|
const view = render(<BashRow {...rowProps(settled({
|
|
call: { name: 'bash', argsRaw: JSON.stringify({ command: 'ls -la' }) },
|
|
}))} />)
|
|
const row = view.container.querySelector('[data-sample="bash"]')!
|
|
expect(view.getByText('ls -la')).toBeTruthy()
|
|
expect(row.getAttribute('role')).toBe('button')
|
|
expect(row.getAttribute('aria-expanded')).toBe('false')
|
|
|
|
fireEvent.click(row)
|
|
|
|
expect(row.getAttribute('aria-expanded')).toBe('true')
|
|
expect(view.getByText('输入')).toBeTruthy()
|
|
expect(view.getByText('输出')).toBeTruthy()
|
|
expect(view.getByText(/"command": "ls -la"/)).toBeTruthy()
|
|
expect(view.container.querySelector('[class*="_ioText_"][data-error]')).toBeNull()
|
|
expect(view.container.querySelectorAll('[class*="_ioText_"]')[1]?.textContent)
|
|
.toBe('a.ts b.ts\nc.ts d.ts\n')
|
|
})
|
|
|
|
it('a non-terminal bash call (background start) renders the summary row alone', () => {
|
|
const view = render(<BashRow {...rowProps(settled({
|
|
call: { name: 'bash', argsRaw: shellArgs({ command: 'sleep 30', description: 'Wait', run_in_background: true }) },
|
|
content: [{ type: 'text', text: 'started background job job-1' }],
|
|
}))} />)
|
|
expect(view.getByText('Wait')).toBeTruthy()
|
|
expect(view.queryByText(/a\.ts/)).toBeNull()
|
|
expect(view.container.querySelector('[data-sample="bash"]')?.getAttribute('role')).toBeNull()
|
|
})
|
|
|
|
it('expands a generic execution error to its original args and full output', () => {
|
|
const view = render(<BashRow {...rowProps(settled({
|
|
content: [{ type: 'text', text: 'Error: command aborted' }],
|
|
isError: true,
|
|
}))} />)
|
|
const row = view.container.querySelector('[data-sample="bash"]')!
|
|
expect(row.getAttribute('role')).toBe('button')
|
|
expect(row.getAttribute('aria-expanded')).toBe('false')
|
|
expect(view.queryByText(/"command": "ls -la"/)).toBeNull()
|
|
|
|
fireEvent.click(row)
|
|
|
|
expect(row.getAttribute('aria-expanded')).toBe('true')
|
|
expect(view.getByText('输入')).toBeTruthy()
|
|
expect(view.getByText('输出')).toBeTruthy()
|
|
expect(view.getByText(/"command": "ls -la"/)).toBeTruthy()
|
|
expect(view.container.querySelector('[data-error]')?.textContent).toBe('Error: command aborted')
|
|
})
|
|
})
|
|
|
|
describe('DetailsPanel Output section', () => {
|
|
function mount(snapshot: ChatSnapshot, selection: SelectionTarget | null, cwd?: string) {
|
|
localStorage.clear()
|
|
const chat = createChatStore().create()
|
|
if (selection !== null) chat.actions.select(selection)
|
|
const sessions = createSnapshotStore<SessionListState>(cwd === undefined
|
|
? { ids: [], byId: {}, current: undefined, phase: 'ready', subagentsByParent: {}, jobsBySession: {}, currentAddress: undefined }
|
|
: {
|
|
ids: [SID],
|
|
byId: { [SID]: { id: SID, displayTitle: 'r', running: false, blank: false, updatedAt: 0, cwd } },
|
|
current: SID,
|
|
phase: 'ready',
|
|
subagentsByParent: {}, jobsBySession: {},
|
|
currentAddress: undefined,
|
|
})
|
|
const session = createSnapshotStore(sessionSnapshot(SID))
|
|
const conversation = createSnapshotStore(conversationSnapshot())
|
|
const workspaces = createSnapshotStore(workspaceSnapshot())
|
|
const attention = createSnapshotStore(new Map())
|
|
return render(
|
|
<DetailsPanel
|
|
renderSlot={renderToolDetails(t)}
|
|
SessionProvider={({ children }) => children}
|
|
sessionId={SID}
|
|
useSession={bindSnapshotSelector(session)}
|
|
useSessions={bindSnapshotSelector(sessions)}
|
|
useSessionPendingInteraction={bindSnapshotSelector(attention)}
|
|
useWorkspaces={bindSnapshotSelector(workspaces)}
|
|
useConversation={bindSnapshotSelector(conversation)}
|
|
useChat={bindSnapshotSelector({ getSnapshot: () => snapshot, subscribe: () => () => {} })}
|
|
useTrajectory={useEmptyTrajectory}
|
|
useInput={(() => { throw new Error('unused') })}
|
|
inputActions={{ setDraft: () => {}, addImages: () => true, removeImage: () => {}, pruneImages: () => {}, submit: () => {} }}
|
|
useProjection={(() => undefined)}
|
|
useStore={bindSnapshotSelector(chat)}
|
|
actions={chat.actions}
|
|
closeDetails={vi.fn()}
|
|
t={chatT}
|
|
/>,
|
|
)
|
|
}
|
|
|
|
function snapshot(over: {
|
|
nodes?: readonly ConversationNode[]
|
|
runningCalls?: readonly RunningToolCall[]
|
|
} = {}): ChatSnapshot {
|
|
const nodes = over.nodes ?? []
|
|
const runningCalls = over.runningCalls ?? []
|
|
return toolChatSnapshot(nodes, runningCalls)
|
|
}
|
|
|
|
const target: SelectionTarget = { turnSeq: 10, callId: 'c1', toolName: 'bash' }
|
|
|
|
// The panel never unmounts between selections, so per-call view state has to
|
|
// be keyed off the selected call or it leaks into the next one.
|
|
it('resets the card\'s expand state when the selected call changes', () => {
|
|
const long = Array.from({ length: 20 }, (_, i) => `row-${i}`)
|
|
const view = mount(snapshot({
|
|
nodes: [settled({ content: [{ type: 'text', text: `${long.join('\n')}\n` }] })],
|
|
}), target)
|
|
fireEvent.click(view.getByRole('button', { name: '展开其余 4 行输出' }))
|
|
expect(view.getByRole('button', { name: '收起输出' })).toBeTruthy()
|
|
// A second call, selected without unmounting the panel, starts collapsed.
|
|
cleanup()
|
|
const second = mount(snapshot({
|
|
nodes: [settled({
|
|
callId: 'c2', content: [{ type: 'text', text: `${long.join('\n')}\n` }],
|
|
})],
|
|
}), { turnSeq: 10, callId: 'c2', toolName: 'bash' })
|
|
expect(second.getByRole('button', { name: '展开其余 4 行输出' })).toBeTruthy()
|
|
})
|
|
|
|
it('renders the raw call description above the card', () => {
|
|
const view = mount(snapshot({
|
|
nodes: [settled({ call: { name: 'bash', argsRaw: shellArgs({ description: 'Terminal 3' }) } })],
|
|
}), target)
|
|
const description = view.getByText('Terminal 3')
|
|
const card = view.container.querySelector('[data-terminal]')
|
|
expect(card).not.toBeNull()
|
|
// Above, not below: document order is what places it as the card's heading.
|
|
expect(description.compareDocumentPosition(card!) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy()
|
|
})
|
|
|
|
it('localizes terminal_send copy in Details', () => {
|
|
const argsRaw = JSON.stringify({ sessionId: 'pty-3', text: '' })
|
|
const view = mount(snapshot({
|
|
nodes: [settled({
|
|
call: { name: 'terminal_send', argsRaw },
|
|
content: [{ type: 'text', text: 'ok' }],
|
|
})],
|
|
}), { ...target, toolName: 'terminal_send' })
|
|
expect(view.getByText('终端 pty-3')).toBeTruthy()
|
|
expect(view.getByText('(发送输入)')).toBeTruthy()
|
|
})
|
|
|
|
it('resolves the prompt cwd against the session workspace', () => {
|
|
const view = mount(snapshot({ nodes: [settled()] }), target, '/w/app')
|
|
// No workdir in the call args: the prompt label is the workspace basename.
|
|
expect(view.getByText('app')).toBeTruthy()
|
|
})
|
|
|
|
it('renders the terminal card at full height, keeping the JSON Input section', () => {
|
|
const long = Array.from({ length: 20 }, (_, i) => `row-${i}`)
|
|
const view = mount(snapshot({
|
|
nodes: [settled({ content: [{ type: 'text', text: `${long.join('\n')}\n` }] })],
|
|
}), target)
|
|
expect(view.getByText(/"command"/)).toBeTruthy()
|
|
expect(view.getByText('ls -la')).toBeTruthy()
|
|
// The panel takes the primitive's own default cap (16), not the row's.
|
|
expect(view.getByText(`… 其余 ${20 - 16} 行`)).toBeTruthy()
|
|
expect(view.getByText('row-0')).toBeTruthy()
|
|
})
|
|
|
|
it('a running terminal call shows the prompt line, not the 运行中… placeholder', () => {
|
|
const view = mount(snapshot({ runningCalls: [running()] }), target)
|
|
expect(view.getByText('ls -la')).toBeTruthy()
|
|
expect(view.queryByText('运行中…')).toBeNull()
|
|
expect(runStateOf(view.container)).toBe('ongoing')
|
|
})
|
|
|
|
it('a running non-terminal call keeps the 运行中… placeholder', () => {
|
|
const view = mount(snapshot({ runningCalls: [running({ argsRaw: shellArgs({ run_in_background: true }) })] }), target)
|
|
expect(view.getByText('运行中…')).toBeTruthy()
|
|
})
|
|
|
|
it('a non-terminal result keeps the flattened pre with its error styling', () => {
|
|
const view = mount(snapshot({
|
|
nodes: [settled({
|
|
isError: true,
|
|
content: [{ type: 'text', text: 'permission denied' }],
|
|
})],
|
|
}), target)
|
|
const pre = view.container.querySelector('pre[data-error]')
|
|
expect(pre?.textContent).toBe('permission denied')
|
|
})
|
|
|
|
it('a Code Dispatch child keeps the flattened form despite valid terminal raw fields', () => {
|
|
const child = settled({ callId: 'c1', parentCallId: 'p1' })
|
|
const view = mount(snapshot({
|
|
runningCalls: [running({ callId: 'p1', subCalls: [child] })],
|
|
}), target)
|
|
// No terminal card: the generic path renders the result text in the Output
|
|
// section's <pre> (the Input section has its own, hence the scoping).
|
|
expect(view.container.querySelector('[data-terminal]')).toBeNull()
|
|
const output = view.getByText('输出').closest('section')
|
|
expect(output?.querySelector('pre')?.textContent).toContain('a.ts b.ts')
|
|
})
|
|
|
|
it('a running Code Dispatch child keeps the running placeholder', () => {
|
|
const view = mount(snapshot({
|
|
// The leading non-matching sub-call exercises the scan's skip.
|
|
runningCalls: [running({
|
|
callId: 'p1',
|
|
subCalls: [
|
|
running({ callId: 'other', parentCallId: 'p1' }),
|
|
running({ parentCallId: 'p1' }),
|
|
],
|
|
})],
|
|
}), target)
|
|
expect(view.getByText('运行中…')).toBeTruthy()
|
|
expect(view.container.querySelector('[data-terminal]')).toBeNull()
|
|
})
|
|
|
|
it('a window-truncated call head titles the panel by callId and drops the Input section', () => {
|
|
const view = mount(snapshot({
|
|
nodes: [settled({ call: null })],
|
|
}), target)
|
|
expect(view.getByText('c1')).toBeTruthy()
|
|
expect(view.queryByText('输入')).toBeNull()
|
|
expect(view.getByText('输出')).toBeTruthy()
|
|
})
|
|
|
|
it('scans past other nodes and other calls before reporting the call out of window', () => {
|
|
const view = mount(snapshot({
|
|
nodes: [
|
|
{ kind: 'assistant', seq: 1, time: 1_000, turn: 1, step: 1, blocks: [] },
|
|
settled({ callId: 'elsewhere' }),
|
|
],
|
|
runningCalls: [running({ callId: 'also-elsewhere' })],
|
|
}), target)
|
|
expect(view.getByText('该调用不在当前窗口内')).toBeTruthy()
|
|
})
|
|
|
|
it('no selection at all renders the guidance line and the default title', () => {
|
|
const view = mount(snapshot(), null)
|
|
expect(view.getByText('详情')).toBeTruthy()
|
|
expect(view.getByText('点击消息流中的工具行查看详情')).toBeTruthy()
|
|
})
|
|
|
|
it('a step selection without a callId renders the guidance line too', () => {
|
|
const view = mount(snapshot(), { turnSeq: 3, stepSeq: 1 })
|
|
expect(view.getByText('点击消息流中的工具行查看详情')).toBeTruthy()
|
|
})
|
|
|
|
it('the close button reaches closeDetails', () => {
|
|
localStorage.clear()
|
|
const chat = createChatStore().create()
|
|
const closeDetails = vi.fn()
|
|
const snap = snapshot()
|
|
const session = createSnapshotStore(sessionSnapshot(SID))
|
|
const conversation = createSnapshotStore(conversationSnapshot())
|
|
const workspaces = createSnapshotStore(workspaceSnapshot())
|
|
const attention = createSnapshotStore(new Map())
|
|
const view = render(
|
|
<DetailsPanel
|
|
renderSlot={renderToolDetails(t)}
|
|
SessionProvider={({ children }) => children}
|
|
sessionId={SID}
|
|
useSession={bindSnapshotSelector(session)}
|
|
useSessions={bindSnapshotSelector(createSnapshotStore<SessionListState>(
|
|
{
|
|
ids: [], byId: {}, current: undefined, phase: 'ready',
|
|
subagentsByParent: {}, jobsBySession: {}, currentAddress: undefined,
|
|
}))}
|
|
useSessionPendingInteraction={bindSnapshotSelector(attention)}
|
|
useWorkspaces={bindSnapshotSelector(workspaces)}
|
|
useConversation={bindSnapshotSelector(conversation)}
|
|
useChat={bindSnapshotSelector({ getSnapshot: () => snap, subscribe: () => () => {} })}
|
|
useTrajectory={useEmptyTrajectory}
|
|
useInput={(() => { throw new Error('unused') })}
|
|
inputActions={{ setDraft: () => {}, addImages: () => true, removeImage: () => {}, pruneImages: () => {}, submit: () => {} }}
|
|
useProjection={(() => undefined)}
|
|
useStore={bindSnapshotSelector(chat)}
|
|
actions={chat.actions}
|
|
closeDetails={closeDetails}
|
|
t={chatT}
|
|
/>,
|
|
)
|
|
fireEvent.click(view.getByRole('button', { name: '关闭详情' }))
|
|
expect(closeDetails).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('a non-text result block renders as JSON, and an empty result falls back to its error', () => {
|
|
const nonText = mount(snapshot({
|
|
nodes: [settled({
|
|
content: [{ type: 'reasoning', text: 'why' }],
|
|
})],
|
|
}), target)
|
|
// Scope to the Output section: the Input section's CodeBlock renders a
|
|
// <pre> of its own, and it comes first in document order.
|
|
expect(nonText.getByText('输出').closest('section')?.querySelector('pre')?.textContent)
|
|
.toBe('{\n "type": "reasoning",\n "text": "why"\n}')
|
|
cleanup()
|
|
const empty = mount(snapshot({
|
|
nodes: [settled({
|
|
content: [], isError: true,
|
|
error: { name: 'ToolError', code: 'interrupted' },
|
|
})],
|
|
}), target)
|
|
expect(empty.getByText('ToolError: interrupted')).toBeTruthy()
|
|
})
|
|
})
|