deepseek-harness/packages/hooks/hooks-codex/tests
Tianyi Cui a4152705ef fix review finding: abort tests must prove the hook process is gone
Codex review of the draft: the abort-on-dispose tests asserted only that
dispose() resolved and no warning fired — a regression back to untracked
fire-and-forget runs would pass both. The hook script now records its
shell PID before sleeping, and after dispose the test asserts
process.kill(pid, 0) throws: the drain resolves only after the killed
run settled (the child reaped), so ESRCH-by-dispose-return is
deterministic under the correct implementation, while an alive or
unreaped process fails it. Verified the discriminator by gutting drain()
locally: exactly these two tests fail.
2026-07-07 00:02:10 +08:00
..
bridge.spec.ts fix review finding: abort tests must prove the hook process is gone 2026-07-07 00:02:10 +08:00
config.spec.ts feat(hooks): dsh-hooks-claude + dsh-hooks-codex bridges (hooks stack PR-F) 2026-07-01 04:23:49 +08:00
coverage.spec.ts Merge remote-tracking branch 'origin/master' into simpl-g-hook-contract 2026-07-04 21:08:50 +08:00