kevchess15/deepseek-harness
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test(spill-local): v8-ignore the two race-only sweep catch branches

Browse source 
The exact-shape fix added two filesystem-failure catch branches that only
fire on a race/permission fault the caller already guards against (the
session-dir readdir after an isDirectory() check, and the discovered-root
rmdir after the root was observed empty). Neither is deterministically
reproducible in-process, so tag both with the same reasoned v8 ignore the
sibling catch blocks already use, restoring per-file 100% coverage and the
symmetry between the parallel rmdir handlers.
This commit is contained in:
Dudu-0223 2026-07-20 14:55:21 +08:00
parent c6a4de6207
commit dbb3bcca8e
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/spill/spill-local/src/store.ts
View file

@ -225,11 +225,13 @@ async function sweepSessionDir(dir: string, cutoffMs: number, warn: WarnFn): Pro
try {
names = await readdir(dir)
} catch (error: unknown) {
// A `session-*` entry that is not a readable directory (a stray file, or an
// unreadable/vanished dir) is not ours to fix — report and leave it. False
// keeps it out of the prune step.
/* v8 ignore start -- the caller lstat'd this entry and confirmed a real
directory just before the call, so readdir fails only when the dir races
away (ENOENT) or a permission/IO fault strikes in that window; not
deterministically reproducible. False keeps it out of the prune step. */
warn(`spill-local: failed to read ${dir}: ${String(error)}`)
return false
/* v8 ignore stop */
}
let remaining = names.length
for (const name of names) {
@ -328,12 +330,15 @@ export async function sweepSpillRoots(options: SweepOptions): Promise<void> {
try {
await rmdir(root.path)
} catch (error: unknown) {
// A concurrent process may have written a fresh spill into this root
// after our scan (ENOTEMPTY), or removed it already (ENOENT) — benign
// races. Anything else is reported.
/* v8 ignore start -- prune runs only on a root whose every child was
reclaimed; a failure here means a concurrent writer added a fresh
spill after our scan (ENOTEMPTY) or removed the root already (ENOENT)
or a permission/IO fault struck — all races outside deterministic
in-process testing. */
if (!isErrno(error, 'ENOENT') && !isErrno(error, 'ENOTEMPTY')) {
warn(`spill-local: failed to prune root ${root.path}: ${String(error)}`)
}
/* v8 ignore stop */
}
}
}